Skip to content

feat:upgrade trace plugin. #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat:upgrade trace plugin. #1467

merged 1 commit into from
Dec 3, 2024

Conversation

SkyeBeFreeman
Copy link
Collaborator

PR Type

Refactoring (no functional changes, no api changes).

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.
  • Will pull request to branch of 2022.
  • Will pull request to branch of 2021.
  • Will pull request to branch of 2020.
  • Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.0.0 milestone Dec 3, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.42857% with 17 lines in your changes missing coverage. Please review.

Project coverage is 65.79%. Comparing base (7744a93) to head (3e6e465).
Report is 1 commits behind head on hoxton.

Files with missing lines Patch % Lines
...in/java/com/tencent/cloud/common/util/OtUtils.java 66.66% 4 Missing and 3 partials ⚠️
...olaris/loadbalancer/PolarisServerIntrospector.java 14.28% 6 Missing ⚠️
...ig/extend/tsf/TsfCoreEnvironmentPostProcessor.java 0.00% 3 Missing ⚠️
.../rpc/enhancement/plugin/EnhancedPluginContext.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             hoxton    #1467      +/-   ##
============================================
- Coverage     65.93%   65.79%   -0.14%     
  Complexity        2        2              
============================================
  Files           338      340       +2     
  Lines          8043     8078      +35     
  Branches        965      971       +6     
============================================
+ Hits           5303     5315      +12     
- Misses         2295     2309      +14     
- Partials        445      454       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrewshan
andrewshan approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit ee9005f into Tencent:hoxton Dec 3, 2024
9 of 10 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the h/tsf-trace branch December 3, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewshan andrewshan andrewshan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@SkyeBeFreeman @andrewshan